fix(peers): widen peer ranges to allow 0.74.x alongside 0.75.x#10
Closed
ta3pks wants to merge 1 commit into
Closed
fix(peers): widen peer ranges to allow 0.74.x alongside 0.75.x#10ta3pks wants to merge 1 commit into
ta3pks wants to merge 1 commit into
Conversation
Author
|
is there act reason for not merging this? |
Owner
Sorry, but it was actually already added and fix in my local changes before. It's just that I mainly take longer to released to verify completely myself that everything is fine. It's already released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widen the
@earendil-works/pi-{coding-agent,tui}peer ranges inpackage.jsonfrom^0.75.4to>=0.74.0 <0.76.0.Why
The current
^0.75.4ceiling (<0.76.0) conflicts with any package that peers at^0.74.0(e.g.pi-powerline-footer) because npm resolves peer intersection to0.74.x, then finds^0.75.4unsatisfiable.pi updatefails withERESOLVE.When
pi updaterunsnpm install, npm picks the lowest version satisfying the broadest peer range. Withpi-simplifyandpi-powerline-footeron^0.74.0(or the widened>=0.74.0 <0.76.0), npm selects0.74.2-- which is excluded bypi-rtk-optimizer's^0.75.4.This is the same class of fix as MattDevy/pi-extensions#127 (pi-simplify, already merged and published as v0.2.2).
Test plan
pi updateon a host withpi-simplify,pi-powerline-footer, andpi-rtk-optimizerinstalled -- should resolve cleanly without--legacy-peer-depsRelease notes
Peer ranges widened from
^0.75.4to>=0.74.0 <0.76.0for both@earendil-works/pi-coding-agentand@earendil-works/pi-tui.